Define SOL_TCP and SOL_UDP for WASIp1 - #876
Closed
Hokila wants to merge 1 commit into
Closed
Conversation
Collaborator
|
Personally I feel that given the state of networking on the wasip1 target, which is mostly broken, I am not confident myself in landing changes like this. I think it would be best to leave the wasip1 target as-is and focus on fixing/improving the targets with actual support for networking in wasip2/wasip3. Do you have a specific motivation though for proposing this change? |
Author
|
Thanks, that makes sense. I don't currently have a concrete WASIp1 networking use case beyond fixing the inconsistency between predefined-macros.txt and <sys/socket.h>. Since this does not improve runtime networking support, I agree that it may not be worth extending the WASIp1 surface. I’m happy to close this PR and focus on WASIp2/WASIp3 instead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SOL_TCPandSOL_UDPfor the WASIp1<sys/socket.h>pathFixes #855.
Testing
git diff --checkEnvironment limitations
cargo test --manifest-path tools/wasi-headers/Cargo.tomlreaches the existingassert_same_as_srctest but fails because the checked-inwasi/api.halready differs from the generator outputarrejecting the project's empty archive command